[
https://issues.apache.org/jira/browse/GOBBLIN-2132?focusedWorklogId=930292&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-930292
]
ASF GitHub Bot logged work on GOBBLIN-2132:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 14/Aug/24 22:58
Start Date: 14/Aug/24 22:58
Worklog Time Spent: 10m
Work Description: Will-Lo commented on code in PR #4026:
URL: https://github.com/apache/gobblin/pull/4026#discussion_r1717640592
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/proc/ResumeDagProc.java:
##########
@@ -71,6 +71,7 @@ protected void act(DagManagementStateStore
dagManagementStateStore, Optional<Dag
long flowResumeTime = System.currentTimeMillis();
// Set the flow and its failed or cancelled nodes to PENDING_RESUME so
that the flow will be resumed from the point before it failed
+ failedDag.get().setFlowEvent(TimingEvent.FlowTimings.FLOW_PENDING_RESUME);
Review Comment:
Setting the flowEvent doesn't mean that the event gets emitted immediately.
Do you want to change that behavior?
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/proc/LaunchDagProc.java:
##########
@@ -77,6 +80,10 @@ protected void act(DagManagementStateStore
dagManagementStateStore, Optional<Dag
dagProcEngineMetrics.markDagActionsAct(getDagActionType(), false);
} else {
DagProcUtils.submitNextNodes(dagManagementStateStore, dag.get(),
getDagId());
+ dag.get().setFlowEvent(TimingEvent.FlowTimings.FLOW_RUNNING);
+ DagManagerUtils.emitFlowEvent(eventSubmitter, dag.get(),
TimingEvent.FlowTimings.FLOW_RUNNING);
Review Comment:
We want to make sure this is just emit a single time - it shouldn't create
multiple flow launch events for a multihop dag flow, correct?
Issue Time Tracking
-------------------
Worklog Id: (was: 930292)
Remaining Estimate: 0h
Time Spent: 10m
> set and emit flow running status
> --------------------------------
>
> Key: GOBBLIN-2132
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2132
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
