arjun4084346 commented on code in PR #4032:
URL: https://github.com/apache/gobblin/pull/4032#discussion_r1723830180
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/MysqlDagStateStoreWithDagNodes.java:
##########
@@ -77,20 +77,18 @@ public class MysqlDagStateStoreWithDagNodes implements
DagStateStoreWithDagNodes
protected final GsonSerDe<List<JobExecutionPlan>> serDe;
private final JobExecutionPlanDagFactory jobExecPlanDagFactory;
- // todo add a column that tells if it is a running dag or a failed dag
protected static final String CREATE_TABLE_STATEMENT = "CREATE TABLE IF NOT
EXISTS %s ("
- + "dag_node_id VARCHAR(" + ServiceConfigKeys.MAX_DAG_NODE_ID_LENGTH + ")
CHARACTER SET latin1 COLLATE latin1_bin NOT NULL, "
- + "parent_dag_id VARCHAR(" + ServiceConfigKeys.MAX_DAG_ID_LENGTH + ")
NOT NULL, "
- + "dag_node JSON NOT NULL, "
+ + "dag_node_id VARCHAR(" + ServiceConfigKeys.MAX_DAG_NODE_ID_LENGTH
+ + ") CHARACTER SET latin1 COLLATE latin1_bin NOT NULL, " +
"parent_dag_id VARCHAR("
+ + ServiceConfigKeys.MAX_DAG_ID_LENGTH + ") NOT NULL, " + "dag_node JSON
NOT NULL, "
+ "modified_time timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE
CURRENT_TIMESTAMP, "
- + "PRIMARY KEY (dag_node_id), "
- + "UNIQUE INDEX dag_node_index (dag_node_id), "
- + "INDEX dag_index (parent_dag_id))";
-
- protected static final String INSERT_STATEMENT = "INSERT INTO %s
(dag_node_id, parent_dag_id, dag_node) "
- + "VALUES (?, ?, ?) AS new ON DUPLICATE KEY UPDATE dag_node =
new.dag_node";
- protected static final String GET_DAG_NODES_STATEMENT = "SELECT dag_node
FROM %s WHERE parent_dag_id = ?";
- protected static final String GET_DAG_NODE_STATEMENT = "SELECT dag_node FROM
%s WHERE dag_node_id = ?";
+ + "is_failed_dag INT NOT NULL DEFAULT 0, " + "PRIMARY KEY (dag_node_id),
"
+ + "UNIQUE INDEX dag_node_index (dag_node_id), " + "INDEX dag_index
(parent_dag_id))";
+
+ protected static final String INSERT_STATEMENT = "INSERT INTO %s
(dag_node_id, parent_dag_id, dag_node, is_failed_dag) "
+ + "VALUES (?, ?, ?, ?) AS new ON DUPLICATE KEY UPDATE dag_node =
new.dag_node, is_failed_dag = new.is_failed_dag";
+ protected static final String GET_DAG_NODES_STATEMENT = "SELECT
dag_node,is_failed_dag FROM %s WHERE parent_dag_id = ?";
+ protected static final String GET_DAG_NODE_STATEMENT = "SELECT
dag_node,is_failed_dag FROM %s WHERE dag_node_id = ?";
Review Comment:
space after comma
To make the space after a comma a suggestion in IntelliJ IDEA rather than a
strict violation, you can use IntelliJ's code style settings instead of
Checkstyle. Here's how you can configure it:
Open Code Style Settings:
Go to File > Settings (or Preferences on macOS).
Navigate to Editor > Code Style > Java.
Set the Space After Comma Rule:
In the Spaces tab, find the option After comma (,).
Make sure this option is checked. This ensures that IntelliJ suggests adding
a space after commas.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
