[
https://issues.apache.org/jira/browse/GOBBLIN-2142?focusedWorklogId=931791&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-931791
]
ASF GitHub Bot logged work on GOBBLIN-2142:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 26/Aug/24 17:26
Start Date: 26/Aug/24 17:26
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on code in PR #4037:
URL: https://github.com/apache/gobblin/pull/4037#discussion_r1731568821
##########
gobblin-service/src/test/java/org/apache/gobblin/service/modules/orchestration/DagManagerUtilsTest.java:
##########
@@ -209,6 +255,19 @@ public void
testIsDagFinishedWithFinishRunningFailureOption() throws URISyntaxEx
Assert.assertFalse(DagProcUtils.isDagFinished(dag));
}
+ private List<Dag.DagNode<JobExecutionPlan>>
randomizeNodes(Dag<JobExecutionPlan> dag) {
+ int size = dag.getNodes().size();
+ List<Dag.DagNode<JobExecutionPlan>> randomizedDagNodes = new ArrayList<>();
+
+ for (int i=0; i<size; i++) {
+ int index = rand.nextInt(size);
+ randomizedDagNodes.add(dag.getNodes().get(index));
+ }
+
+ return randomizedDagNodes;
+
+ }
Review Comment:
oh , forgot to clean this method. was trying to randomize using this way,
but found something more elegant
Issue Time Tracking
-------------------
Worklog Id: (was: 931791)
Time Spent: 2h 50m (was: 2h 40m)
> find if the dag is running or not correctly
> -------------------------------------------
>
> Key: GOBBLIN-2142
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2142
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
