[
https://issues.apache.org/jira/browse/GOBBLIN-2143?focusedWorklogId=932521&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-932521
]
ASF GitHub Bot logged work on GOBBLIN-2143:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 29/Aug/24 22:33
Start Date: 29/Aug/24 22:33
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on code in PR #4038:
URL: https://github.com/apache/gobblin/pull/4038#discussion_r1737295143
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/MySqlDagManagementStateStore.java:
##########
@@ -142,8 +142,11 @@ public void markDagFailed(DagManager.DagId dagId) throws
IOException {
@Override
public void deleteDag(DagManager.DagId dagId) throws IOException {
- this.dagStateStore.cleanUp(dagId);
- log.info("Deleted dag {}", dagId);
+ if (this.dagStateStore.cleanUp(dagId)) {
+ log.info("Deleted dag {}", dagId);
+ } else {
+ log.info("Dag deletion was tried but did not happen {}", dagId);
Review Comment:
i mean, i intend to not swallow exceptions.
and i am just fine if cleanup returns false. so did not do try/catch
Issue Time Tracking
-------------------
Worklog Id: (was: 932521)
Time Spent: 1h 10m (was: 1h)
> handle concurrent ReevaluateDagProc for cancelled dag nodes correctly
> ---------------------------------------------------------------------
>
> Key: GOBBLIN-2143
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2143
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
