[ 
https://issues.apache.org/jira/browse/GOBBLIN-2136?focusedWorklogId=932532&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-932532
 ]

ASF GitHub Bot logged work on GOBBLIN-2136:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 30/Aug/24 01:39
            Start Date: 30/Aug/24 01:39
    Worklog Time Spent: 10m 
      Work Description: arjun4084346 commented on code in PR #4031:
URL: https://github.com/apache/gobblin/pull/4031#discussion_r1737615489


##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/flow/BaseFlowToJobSpecCompiler.java:
##########
@@ -74,7 +74,7 @@ public abstract class BaseFlowToJobSpecCompiler implements 
SpecCompiler {
   // to these data structures.
   @Getter
   @Setter
-  protected final Map<URI, TopologySpec> topologySpecMap;
+  protected Map<URI, TopologySpec> topologySpecMap;

Review Comment:
   yea it should be.... i thought if there is a @Setter it should not be final. 
removed the @Setter instead





Issue Time Tracking
-------------------

    Worklog Id:     (was: 932532)
    Time Spent: 50m  (was: 40m)

> remove obsolete code related to DagManager
> ------------------------------------------
>
>                 Key: GOBBLIN-2136
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-2136
>             Project: Apache Gobblin
>          Issue Type: Task
>            Reporter: Arjun Singh Bora
>            Priority: Major
>          Time Spent: 50m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to