[ 
https://issues.apache.org/jira/browse/GOBBLIN-2146?focusedWorklogId=932763&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-932763
 ]

ASF GitHub Bot logged work on GOBBLIN-2146:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 31/Aug/24 15:15
            Start Date: 31/Aug/24 15:15
    Worklog Time Spent: 10m 
      Work Description: Will-Lo opened a new pull request, #4043:
URL: https://github.com/apache/gobblin/pull/4043

   …ation
   
   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I 
have checked off all the steps below!
   
   
   ### JIRA
   - [ ] My PR addresses the following [Gobblin 
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references 
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
       - https://issues.apache.org/jira/browse/GOBBLIN-2146
   
   
   ### Description
   - [ ] Here are some details about my PR, including screenshots (if 
applicable):
   Instead of `setFlowEvent`, the proc engine needs to enforce that flow level 
events are always being emitted for each type of flow. In this scenario, it 
needs to emit flow level events for cancellation at a flow level so that jobs 
are properly killed, similar to the DagManager.
   
   ### Tests
   - [ ] My PR adds the following unit tests __OR__ does not need testing for 
this extremely good reason:
   
   
   ### Commits
   - [ ] My commits all reference JIRA issues in their subject lines, and I 
have squashed multiple commits if they address the same issue. In addition, my 
commits follow the guidelines from "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   




Issue Time Tracking
-------------------

            Worklog Id:     (was: 932763)
    Remaining Estimate: 0h
            Time Spent: 10m

> GaaS SLA flow cancellation is not emitting a flow event which blocks incoming 
> jobs
> ----------------------------------------------------------------------------------
>
>                 Key: GOBBLIN-2146
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-2146
>             Project: Apache Gobblin
>          Issue Type: Bug
>            Reporter: William Lo
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> GaaS is not emitting flow level events when SLA killing jobs. This needs to 
> be fixed otherwise the flow status reporting becomes incorrect.
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to