[
https://issues.apache.org/jira/browse/GOBBLIN-2148?focusedWorklogId=932981&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-932981
]
ASF GitHub Bot logged work on GOBBLIN-2148:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 03/Sep/24 12:08
Start Date: 03/Sep/24 12:08
Worklog Time Spent: 10m
Work Description: abhishekmjain opened a new pull request, #4045:
URL: https://github.com/apache/gobblin/pull/4045
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN-2148) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-2148
### Description
- [ ] Here are some details about my PR, including screenshots (if
applicable):
Currently, when GaaS Temporal job are cancelled, only the Azkaban job is
stopped, which stops the subsequent YARN application. However, the Temporal job
that is submitted by the YARN application is not stopped.
As part of this PR, we have implemented the cancel flow which should cancel
the Temporal workflow upon cancellation of Azkaban job.
The support for cancellation is added in base class
GobblinTemporalJobLauncher. The workflowId is needed for cancellation, thus
some changes are made to initialize the workflowId in submitJob, which can then
be used for cancellation.
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
- testCancelWorkflowIfFailed
- testCancelWorkflowIfCompleted
- testCancelWorkflowIfRunning
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
Issue Time Tracking
-------------------
Worklog Id: (was: 932981)
Remaining Estimate: 0h
Time Spent: 10m
> Cancelling a GaaS Temporal job should terminate both the Az and Temporal Job
> ----------------------------------------------------------------------------
>
> Key: GOBBLIN-2148
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2148
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Abhishek Jain
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently, when GaaS Temporal job are cancelled, only the Azkaban job is
> stopped, which stops the subsequent YARN application. However, the Temporal
> job that is submitted by the YARN application is not stopped. We want to also
> kill the Temporal job in order to better track our jobs and not waste
> resources on the Temporal side.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
