phet commented on code in PR #4048:
URL: https://github.com/apache/gobblin/pull/4048#discussion_r1744613759
##########
gobblin-service/src/test/java/org/apache/gobblin/service/modules/orchestration/DagManagerUtilsTest.java:
##########
Review Comment:
these are testing `DagProcUtils`... do we have a plan separately to rename
this test class?
##########
gobblin-service/src/test/java/org/apache/gobblin/service/modules/orchestration/DagManagerUtilsTest.java:
##########
@@ -109,15 +118,19 @@ public void testIsDagFinishedTwoNodes() throws
URISyntaxException {
setJobStatuses(dag, Arrays.asList(COMPLETE, PENDING));
Assert.assertFalse(DagProcUtils.isDagFinished(dag));
+ Assert.assertEquals(TimingEvent.FlowTimings.FLOW_RUNNING,
DagProcUtils.calcFlowStatus(dag));
Review Comment:
it took me a minute to realize you were repurposing the tests you just wrote
for `isDagFinished` (which are very good BTW). as a minor suggestion, consider
renaming all of the test methods to reflect the dual purpose. e.g. something
like, `testFlowStatusPlusIsDagFinishedTwoNodes`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
