phet commented on code in PR #4031:
URL: https://github.com/apache/gobblin/pull/4031#discussion_r1744806314
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/scheduler/GobblinServiceJobScheduler.java:
##########
@@ -158,7 +138,7 @@ public class GobblinServiceJobScheduler extends
JobScheduler implements SpecCata
* e.g. There are multi-datacenter deployment of GaaS Cluster.
Intra-datacenter fail-over could be handled by
* leadership change mechanism, while inter-datacenter fail-over would be
handled by DR handling mechanism.
*/
- private boolean isNominatedDRHandler;
+ private final boolean isNominatedDRHandler;
Review Comment:
no, I don't. I see a "skeleton" for DR was added in 2019. for now let's
leave as-is
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
