phet commented on code in PR #4050:
URL: https://github.com/apache/gobblin/pull/4050#discussion_r1753023901
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/utils/FlowCompilationValidationHelper.java:
##########
@@ -216,6 +217,12 @@ static boolean isFlowRunning(String flowGroup, String
flowName, DagManagementSta
}
for (FlowStatus flowStatus : flowStatusList) {
+ if (flowStatus.getFlowExecutionId() == flowExecutionId) {
+ // a duplicate call to this method indicate that the prior caller of
this method could not complete the required action,
+ // so we ignore any flow status for the current execution to give the
caller another chance to complete them
+ continue;
Review Comment:
given we expect re-attempts to be rare, let's at least log this condition.
given we really expect it only in `COMPILED` state, so let's do `.info` level -
but if it's any other status, that merits `.warn`
perhaps if the state is actually `RUNNING` it should even be `.error` level
(what do you think?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
