pratapaditya04 commented on code in PR #4057:
URL: https://github.com/apache/gobblin/pull/4057#discussion_r1764405404
##########
gobblin-api/src/main/java/org/apache/gobblin/util/io/GsonInterfaceAdapter.java:
##########
@@ -189,7 +192,38 @@ private <S> S readValue(JsonObject jsonObject,
TypeToken<S> defaultTypeToken) th
}
public static <T> Gson getGson(Class<T> clazz) {
- Gson gson = new GsonBuilder().registerTypeAdapterFactory(new
GsonInterfaceAdapter(clazz)).create();
+ Gson gson = new GsonBuilder()
+
.setObjectToNumberStrategy(CustomToNumberPolicy.INTEGER_OR_LONG_OR_DOUBLE)
+ .registerTypeAdapterFactory(new GsonInterfaceAdapter(clazz))
+ .create();
return gson;
}
+
+ public enum CustomToNumberPolicy implements ToNumberStrategy {
Review Comment:
nit : minor suggestion on naming :CustomToNumberPolicy sounds a bit generic,
can be renamed to something like GsonNumberParsingPolicy to reflect its
purpose more clearly
.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
