[
https://issues.apache.org/jira/browse/GOBBLIN-2158?focusedWorklogId=935124&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-935124
]
ASF GitHub Bot logged work on GOBBLIN-2158:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 18/Sep/24 05:29
Start Date: 18/Sep/24 05:29
Worklog Time Spent: 10m
Work Description: Blazer-007 commented on code in PR #4057:
URL: https://github.com/apache/gobblin/pull/4057#discussion_r1764408473
##########
gobblin-api/src/main/java/org/apache/gobblin/util/io/GsonInterfaceAdapter.java:
##########
@@ -189,7 +192,38 @@ private <S> S readValue(JsonObject jsonObject,
TypeToken<S> defaultTypeToken) th
}
public static <T> Gson getGson(Class<T> clazz) {
- Gson gson = new GsonBuilder().registerTypeAdapterFactory(new
GsonInterfaceAdapter(clazz)).create();
+ Gson gson = new GsonBuilder()
+
.setObjectToNumberStrategy(CustomToNumberPolicy.INTEGER_OR_LONG_OR_DOUBLE)
+ .registerTypeAdapterFactory(new GsonInterfaceAdapter(clazz))
+ .create();
return gson;
}
+
+ public enum CustomToNumberPolicy implements ToNumberStrategy {
Review Comment:
The library implementation is
`public enum ToNumberPolicy implements ToNumberStrategy`
Since my code is wrapper on top of this that's the reason for keeping it
generic
Issue Time Tracking
-------------------
Worklog Id: (was: 935124)
Time Spent: 2h (was: 1h 50m)
> Upgrade GSON version to 2.8.9
> -----------------------------
>
> Key: GOBBLIN-2158
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2158
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Vivek Rai
> Priority: Major
> Time Spent: 2h
> Remaining Estimate: 0h
>
> Upgrade GSON version to 2.8.9 and add a custom ObjectToIntegerDeserialize
> policy to avoid getting integer converted to double or long while deserialize.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
