[
https://issues.apache.org/jira/browse/GOBBLIN-2159?focusedWorklogId=939492&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-939492
]
ASF GitHub Bot logged work on GOBBLIN-2159:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 22/Oct/24 13:21
Start Date: 22/Oct/24 13:21
Worklog Time Spent: 10m
Work Description: Blazer-007 commented on code in PR #4058:
URL: https://github.com/apache/gobblin/pull/4058#discussion_r1810719341
##########
gobblin-data-management/src/test/java/org/apache/gobblin/data/management/copy/iceberg/IcebergTableTest.java:
##########
@@ -106,15 +113,17 @@ public void testGetCurrentSnapshotInfo() throws
IOException {
);
initializeSnapshots(table, perSnapshotFilesets);
- IcebergSnapshotInfo snapshotInfo = new IcebergTable(tableId,
catalog.newTableOps(tableId), catalogUri).getCurrentSnapshotInfo();
+ IcebergSnapshotInfo snapshotInfo = new IcebergTable(tableId,
catalog.newTableOps(tableId), catalogUri,
+ catalog.loadTable(tableId)).getCurrentSnapshotInfo();
verifySnapshotInfo(snapshotInfo, perSnapshotFilesets,
perSnapshotFilesets.size());
}
/** Verify failure when attempting to get current snapshot info for
non-existent table */
- @Test(expectedExceptions = IcebergTable.TableNotFoundException.class)
+ @Test(expectedExceptions = {IcebergTable.TableNotFoundException.class,
NoSuchTableException.class})
Review Comment:
to throw` IcebergTable.TableNotFoundException.class` exception I can change
catalog.loadTable(tableIdentifier) to null as `NoSuchTableException.class`
comes from catalog.loadTable(tableIdentifier) and catalog here comes from
HiveMetastoreTest and is not our catalogImplementation
Issue Time Tracking
-------------------
Worklog Id: (was: 939492)
Time Spent: 9h (was: 8h 50m)
> Support Partition Based Copy in Iceberg Distcp
> ----------------------------------------------
>
> Key: GOBBLIN-2159
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2159
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Vivek Rai
> Priority: Major
> Time Spent: 9h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
