[
https://issues.apache.org/jira/browse/GOBBLIN-2160?focusedWorklogId=943199&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-943199
]
ASF GitHub Bot logged work on GOBBLIN-2160:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 12/Nov/24 04:05
Start Date: 12/Nov/24 04:05
Worklog Time Spent: 10m
Work Description: Blazer-007 commented on code in PR #4059:
URL: https://github.com/apache/gobblin/pull/4059#discussion_r1837451181
##########
gobblin-temporal/src/test/java/org/apache/gobblin/temporal/ddm/workflow/impl/AbstractNestingExecWorkflowImplTest.java:
##########
@@ -0,0 +1,170 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.gobblin.temporal.ddm.workflow.impl;
+
+import java.util.Optional;
+import java.util.UUID;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import org.testng.Assert;
+import org.testng.annotations.AfterMethod;
+import org.testng.annotations.BeforeMethod;
+import org.testng.annotations.Test;
+
+import io.temporal.api.common.v1.WorkflowExecution;
+import io.temporal.api.history.v1.History;
+import io.temporal.api.history.v1.HistoryEvent;
+import
io.temporal.api.workflowservice.v1.GetWorkflowExecutionHistoryReverseRequest;
+import
io.temporal.api.workflowservice.v1.GetWorkflowExecutionHistoryReverseResponse;
+import io.temporal.client.WorkflowClient;
+import io.temporal.client.WorkflowOptions;
+import io.temporal.serviceclient.WorkflowServiceStubs;
+import io.temporal.worker.Worker;
+import io.temporal.worker.WorkerFactory;
+import io.temporal.api.enums.v1.EventType;
+
+
+import org.apache.gobblin.temporal.loadgen.activity.IllustrationItemActivity;
+import org.apache.gobblin.temporal.loadgen.work.IllustrationItem;
+import org.apache.gobblin.temporal.loadgen.work.SimpleGeneratedWorkload;
+import
org.apache.gobblin.temporal.loadgen.workflow.impl.NestingExecOfIllustrationItemActivityWorkflowImpl;
+import org.apache.gobblin.temporal.util.nesting.work.WorkflowAddr;
+import org.apache.gobblin.temporal.util.nesting.work.Workload;
+import org.apache.gobblin.temporal.util.nesting.workflow.NestingExecWorkflow;
+
+
+public class AbstractNestingExecWorkflowImplTest {
+
+ private static final Logger logger =
LoggerFactory.getLogger(AbstractNestingExecWorkflowImplTest.class);
+
Review Comment:
I don't think we need to log / or print something in tests, can we please
remove them ?
Issue Time Tracking
-------------------
Worklog Id: (was: 943199)
Time Spent: 0.5h (was: 20m)
> Unit tests for Gobblin Temporal Module
> --------------------------------------
>
> Key: GOBBLIN-2160
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2160
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Aditya Pratap Singh
> Priority: Minor
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Unit tests for Gobblin Temporal Module
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
