abhishekmjain commented on code in PR #4076: URL: https://github.com/apache/gobblin/pull/4076#discussion_r1843209572
########## gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/Orchestrator.java: ########## @@ -125,6 +130,7 @@ public AddSpecResponse onAddSpec(Spec addedSpec) { _log.info("Orchestrator - onAdd[Topology]Spec: " + addedSpec); this.specCompiler.onAddSpec(addedSpec); } else if (addedSpec instanceof FlowSpec) { + validateAdhocFlowLeasability((FlowSpec) addedSpec); Review Comment: This check is being done for adhoc as well as scheduled flows. Would suggest to remove Adhoc from the method name. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@gobblin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org