[
https://issues.apache.org/jira/browse/GOBBLIN-2173?focusedWorklogId=944444&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-944444
]
ASF GitHub Bot logged work on GOBBLIN-2173:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 19/Nov/24 18:50
Start Date: 19/Nov/24 18:50
Worklog Time Spent: 10m
Work Description: vsinghal85 commented on code in PR #4076:
URL: https://github.com/apache/gobblin/pull/4076#discussion_r1848878012
##########
gobblin-service/src/test/java/org/apache/gobblin/service/modules/orchestration/OrchestratorTest.java:
##########
@@ -324,10 +323,10 @@ public void createFlowSpec() throws Throwable {
/*
If another flow has already acquired lease for this flowspec details
within
- epsilon time, then we do not execute this flow, hence do not process and
store the spec
- and throw LeaseUnavailableException
+ lease consolidation time, then we do not execute this flow, hence do not
process and store the spec
+ and throw RuntimeException
*/
- @Test(expectedExceptions = TooSoonToRerunSameFlowException.class)
+ @Test(expectedExceptions = RuntimeException.class)
Review Comment:
Sure updated as per suggestion
Issue Time Tracking
-------------------
Worklog Id: (was: 944444)
Time Spent: 5h 10m (was: 5h)
> Adhoc flows are not being deleted from GaaS FlowSpec store
> ----------------------------------------------------------
>
> Key: GOBBLIN-2173
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2173
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: Abhishek Jain
> Assignee: Abhishek Tiwari
> Priority: Critical
> Time Spent: 5h 10m
> Remaining Estimate: 0h
>
> In GaaS, we store adhoc flows temporarily in our flowspec DB in order to
> persist them in service restart/failover scenarios. However, it is expected
> that once these flows are kicked off/ forwarded to the DagProcEngine, they
> need to be removed from our flowspec db.
> This is currently not consistently happening, there seems to be some edge
> case(s) where they are persisted in the db. This can be fatal for users such
> as DIL that run adhoc flows using the same flowgroup/flowname consistently,
> which will lead to their flows being stuck. We need to find which edge cases
> are not handling the flow spec deletion properly.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
