Re: [PR] [GOBBLIN-2168] Compare with the current time in UTC [gobblin]

[via GitHub]

linweihs commented on PR #4070:
URL: https://github.com/apache/gobblin/pull/4070#issuecomment-2489691544

   **Updated 2024/11/20:**
   I found out a bug internally where theres discrepancy between 
java.utils.Properties and Azkaban prop object during props passing, thats 
results in parent config is not pass all the way down to 
`TimeBasedSnapshotCleanupPolicy.java` in runtime.
   
   I've reverted TimeBasedSnapshotCleanupPolicy to original code, and tested 
are expected.  the However, i've added unit tests 
`TimeBasedSnapshotCleanupPolicyTest` ensuring the test coverage.
   
   During investigation, also found a bug (in Trash.java) where Trash use 
`props.contains(TRASH_CLASS_KEY))` which leads to unexpected evalation whereas 
the intention is to `props.containsKey(TRASH_CLASS_KEY))`
   ![Screenshot 2024-11-20 at 2 48 37 
PM](https://github.com/user-attachments/assets/c4bb17d5-8928-4f99-8707-0694f76a209f)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org