Blazer-007 commented on code in PR #4077:
URL: https://github.com/apache/gobblin/pull/4077#discussion_r1862373932
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/yarn/YarnService.java:
##########
@@ -440,7 +430,7 @@ public synchronized boolean
requestTargetNumberOfContainers(int numContainers, S
LOGGER.info("Trying to set numTargetContainers={}, in-use helix instances
count is {}, container map size is {}",
numContainers, inUseInstances.size(), this.containerMap.size());
- requestContainers(numContainers,
Resource.newInstance(defaultContainerMemoryMbs, defaultContainerCores));
+ requestContainers(numContainers,
Resource.newInstance(defaultContainerMemoryMbs, defaultContainerCores),
Optional.absent());
Review Comment:
great catch, was just trying to not modify existing code much so didn't
changed, correcting it to use baselineWorker config and making method private
as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
