abhishekmjain opened a new pull request, #4080:
URL: https://github.com/apache/gobblin/pull/4080

   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I 
have checked off all the steps below!
   
   
   ### JIRA
   - [ ] My PR addresses the following [Gobblin 
JIRA](https://issues.apache.org/jira/browse/GOBBLIN-2177) issues and references 
them in the PR title. For example, "[GOBBLIN-2177] My Gobblin PR"
       - https://issues.apache.org/jira/browse/GOBBLIN-2177
   
   
   ### Description
   - [ ] Here are some details about my PR, including screenshots (if 
applicable):
   The `QueueProcessor` has an infinite while loop which gets stopped upon 
encountering any Exception. This effectively drops the messages being consumed 
post such Exception.
   The implemented fix ensures that for any non-Interrupted Exception, we log 
the occurrence and keep trying to process further messages.
   For InterruptedException, we interrupt the current thread and stop the queue 
processor.
   The infinite while loop is also updated to stop based on shutdown flag.
   
   ### Tests
   - [ ] My PR adds the following unit tests __OR__ does not need testing for 
this extremely good reason:
   Added a unit test to verify all messages are processed, even on encountering 
any Exception.
   
   ### Commits
   - [ ] My commits all reference JIRA issues in their subject lines, and I 
have squashed multiple commits if they address the same issue. In addition, my 
commits follow the guidelines from "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to