phet commented on code in PR #4078: URL: https://github.com/apache/gobblin/pull/4078#discussion_r1876633245
########## gobblin-temporal/src/main/java/org/apache/gobblin/temporal/exception/FailedDatasetUrnsException.java: ########## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.gobblin.temporal.exception; + +import java.io.IOException; + +/** + * An exception thrown when a set of dataset URNs fail to be processed. + */ +public class FailedDatasetUrnsException extends IOException { + + + /** + * Creates a new instance of this exception with the failed dataset URNs. + * + * @param failedDatasetUrns the String of failed dataset URNs joined by comma + */ + public FailedDatasetUrnsException(String failedDatasetUrns) { + super("Failed to process the following dataset URNs: " + failedDatasetUrns); + } Review Comment: rather than passing in a string with multiple URNs already joined, have the ctor take a `List<String>` that keeps them separate. also add a member so those catching the exception may access that list. continuing to format the `super` call w/ the joined URNs as you currently are seems fine -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@gobblin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
