khandelwal-prateek commented on code in PR #4085:
URL: https://github.com/apache/gobblin/pull/4085#discussion_r1906552495
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/GobblinTemporalConfigurationKeys.java:
##########
@@ -43,6 +43,8 @@ public interface GobblinTemporalConfigurationKeys {
String GOBBLIN_TEMPORAL_JOB_LAUNCHER_ARG_PREFIX =
GOBBLIN_TEMPORAL_JOB_LAUNCHER_PREFIX + "arg.";
String GOBBLIN_TEMPORAL_JOB_LAUNCHER_CONFIG_OVERRIDES =
GOBBLIN_TEMPORAL_JOB_LAUNCHER_PREFIX + "config.overrides";
+ String GOBBLIN_TEMPORAL_CLEAN_UP_WORK_DIR = PREFIX + "clean.up.work.dir";
Review Comment:
cleanup should be used as a single word..
`GOBBLIN_TEMPORAL_WORK_DIR_CLEANUP_ENABLED = PREFIX +
"work.dir.cleanup.enabled"`
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/GobblinTemporalConfigurationKeys.java:
##########
@@ -43,6 +43,8 @@ public interface GobblinTemporalConfigurationKeys {
String GOBBLIN_TEMPORAL_JOB_LAUNCHER_ARG_PREFIX =
GOBBLIN_TEMPORAL_JOB_LAUNCHER_PREFIX + "arg.";
String GOBBLIN_TEMPORAL_JOB_LAUNCHER_CONFIG_OVERRIDES =
GOBBLIN_TEMPORAL_JOB_LAUNCHER_PREFIX + "config.overrides";
+ String GOBBLIN_TEMPORAL_CLEAN_UP_WORK_DIR = PREFIX + "clean.up.work.dir";
+ String DEFAULT_GOBBLIN_TEMPORAL_CLEAN_UP_WORK_DIR = "true";
Review Comment:
as this is a boolean, can be renamed to
`DEFAULT_GOBBLIN_TEMPORAL_WORK_DIR_CLEANUP_ENABLED`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
