Blazer-007 commented on code in PR #4086:
URL: https://github.com/apache/gobblin/pull/4086#discussion_r1923496725


##########
gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/KafkaJobStatusMonitor.java:
##########
@@ -233,6 +234,12 @@ protected void 
processMessage(DecodeableKafkaRecord<byte[],byte[]> message) {
           // as much as FAILED does if we chose to emit ObservabilityEvent for 
FAILED_PENDING_RETRY
           boolean retryRequired = modifyStateIfRetryRequired(jobStatus);
 
+          if (Objects.equals(status, "COMPILED")) {
+            this.eventProducer.emitObservabilityEvent(jobStatus);
+          }
+          if (updatedJobStatus.getRight() == NewState.RUNNING) {
+            this.eventProducer.emitObservabilityEvent(jobStatus);

Review Comment:
   Why this difference i.e. using `status` and `updatedJobStatus.getRight()` 
for COMPILED and RUNNING ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to