Blazer-007 commented on code in PR #4093:
URL: https://github.com/apache/gobblin/pull/4093#discussion_r1938791773
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/ddm/workflow/impl/ProcessWorkUnitsWorkflowImpl.java:
##########
@@ -54,37 +54,30 @@ public class ProcessWorkUnitsWorkflowImpl implements
ProcessWorkUnitsWorkflow {
public static final String COMMIT_STEP_WORKFLOW_ID_BASE =
"CommitStepWorkflow";
@Override
- public CommitStats process(WUProcessingSpec workSpec) {
+ public CommitStats process(WUProcessingSpec workSpec, final Properties
props) {
Review Comment:
https://github.com/apache/gobblin/pull/4093#discussion_r1938791672
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/util/nesting/workflow/AbstractNestingExecWorkflowImpl.java:
##########
@@ -84,9 +90,11 @@ public int performWorkload(
if (numDirectLeavesChildMayHave > 0) {
Workflow.sleep(calcPauseDurationBeforeCreatingSubTree(numDirectLeavesChildMayHave));
}
- childSubTrees.add(
- Async.function(child::performWorkload, childAddr, workload,
childStartIndex, maxBranchesPerTree,
- maxSubTreesPerTree,
Optional.of(subTreeChildMaxSubTreesPerTree)));
+ NestingExecWorkloadInput<WORK_ITEM> childInput = new
NestingExecWorkloadInput<>(
Review Comment:
https://github.com/apache/gobblin/pull/4093#discussion_r1938791672
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
