[
https://issues.apache.org/jira/browse/GOBBLIN-2192?focusedWorklogId=955589&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-955589
]
ASF GitHub Bot logged work on GOBBLIN-2192:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 05/Feb/25 14:42
Start Date: 05/Feb/25 14:42
Worklog Time Spent: 10m
Work Description: abhishekmjain commented on code in PR #4095:
URL: https://github.com/apache/gobblin/pull/4095#discussion_r1943070312
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/GobblinTemporalConfigurationKeys.java:
##########
@@ -74,4 +74,14 @@ public interface GobblinTemporalConfigurationKeys {
String DYNAMIC_SCALING_POLLING_INTERVAL_SECS = DYNAMIC_SCALING_PREFIX +
"polling.interval.seconds";
int DEFAULT_DYNAMIC_SCALING_POLLING_INTERVAL_SECS = 60;
+
+ /**
+ * Temporal metrics config properties
+ */
+ String TEMPORAL_METRICS_PREFIX = PREFIX + "metrics.";
+ String TEMPORAL_METRICS_OTLP_PREFIX_WITHOUT_DOT = TEMPORAL_METRICS_PREFIX +
"otlp";
+ String TEMPORAL_METRICS_OTLP_HEADERS_KEY =
TEMPORAL_METRICS_OTLP_PREFIX_WITHOUT_DOT + ".headers";
+ String TEMPORAL_METRICS_REPORT_INTERVAL_SECS =
TEMPORAL_METRICS_OTLP_PREFIX_WITHOUT_DOT + ".report.interval.seconds";
+ int DEFAULT_TEMPORAL_METRICS_REPORT_INTERVAL_SECS = 10;
+ String TEMPORAL_METRICS_OTLP_DIMENSIONS_KEY =
TEMPORAL_METRICS_OTLP_PREFIX_WITHOUT_DOT + ".dimensions";
Review Comment:
We need to parse headers separately since the default config of header
parsing considers ',' as split value. There may be a header key or value which
needs ',' in its string which will not work if we don't have an object mapper.
For dimension there is no config, have mentioned the benefits in above
comment.
For step, there's a default value of 1 min, which seems a bit longer than
the usual 10 seconds reporting interval.
Issue Time Tracking
-------------------
Worklog Id: (was: 955589)
Time Spent: 40m (was: 0.5h)
> Add Metrics support for Temporal workflows
> ------------------------------------------
>
> Key: GOBBLIN-2192
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2192
> Project: Apache Gobblin
> Issue Type: Task
> Components: gobblin-metrics
> Reporter: Abhishek Jain
> Assignee: Issac Buenrostro
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Add metrics support for Temporal workflow
> https://docs.temporal.io/references/sdk-metrics
> https://docs.temporal.io/develop/java/observability#metrics
> https://docs.micrometer.io/micrometer/reference/implementations/otlp.html
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
