Blazer-007 commented on code in PR #4096: URL: https://github.com/apache/gobblin/pull/4096#discussion_r1944863514
########## gobblin-temporal/src/main/java/org/apache/gobblin/temporal/joblauncher/GobblinTemporalJobLauncher.java: ########## @@ -36,6 +36,9 @@ import io.temporal.serviceclient.WorkflowServiceStubs; import io.temporal.workflow.Workflow; +import org.apache.commons.text.TextStringBuilder; +import org.apache.gobblin.cluster.event.JobSummaryEvent; +import org.apache.gobblin.runtime.JobState; Review Comment: Might have missed in first review please update the import order as `Import order: java, org, com, gobblin.` https://gobblin.apache.org/docs/developer-guide/CodingStyle/ ########## gobblin-temporal/src/main/java/org/apache/gobblin/temporal/yarn/YarnService.java: ########## @@ -37,6 +37,8 @@ import java.util.stream.IntStream; import org.apache.commons.lang.StringUtils; +import org.apache.gobblin.cluster.event.JobSummaryEvent; +import org.apache.gobblin.runtime.JobState; Review Comment: similar here as well ########## gobblin-yarn/src/main/java/org/apache/gobblin/yarn/GobblinYarnAppLauncher.java: ########## @@ -380,6 +382,19 @@ public void launch() throws IOException, YarnException, InterruptedException { }, 0, this.appReportIntervalMinutes, TimeUnit.MINUTES); addServices(); + + synchronized (this.applicationDone) { + while (!this.applicationCompleted) { + try { + this.applicationDone.wait(); + if (this.applicationFailed) { + throw new RuntimeException("Gobblin Yarn application failed"); + } + } catch (InterruptedException ie) { + LOGGER.error("Interrupted while waiting for the Gobblin Yarn application to finish", ie); + } + } + } Review Comment: QQ - Can the throwing of RuntimeException affects the shutdown in anyway ? ########## gobblin-temporal/src/test/java/org/apache/gobblin/temporal/yarn/YarnServiceTest.java: ########## @@ -20,6 +20,8 @@ import java.io.IOException; import java.net.URL; +import org.apache.gobblin.cluster.event.JobSummaryEvent; +import org.apache.gobblin.runtime.JobState; Review Comment: here also -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@gobblin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
