abhishekmjain opened a new pull request, #4097: URL: https://github.com/apache/gobblin/pull/4097
Dear Gobblin maintainers, Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below! ### JIRA - [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN-2194) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR" - https://issues.apache.org/jira/browse/GOBBLIN-2194 ### Description - [ ] Here are some details about my PR, including screenshots (if applicable): As part of https://github.com/apache/gobblin/pull/4095, a bug was introduced where the Metrics Scope object was not being closed, resulting in a non-daemon thread being alive. This resulted in AM container not getting shut down on application completion. This PR implements the fix to close metrics scope wherever it is initialized. It also covers calling close on JobLauncher upon its completion, which now results in cleanly closing the resources launched by JobLauncher. ### Tests - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason: Tested in a local project where the application master shuts down.  ### Commits - [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 2. Subject is limited to 50 characters 3. Subject does not end with a period 4. Subject uses the imperative mood ("add", not "adding") 5. Body wraps at 72 characters 6. Body explains "what" and "why", not "how" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@gobblin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
