abhishekmjain commented on code in PR #4097: URL: https://github.com/apache/gobblin/pull/4097#discussion_r1956065492
########## gobblin-temporal/src/main/java/org/apache/gobblin/temporal/workflows/service/ManagedWorkflowServiceStubs.java: ########## @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.gobblin.temporal.workflows.service; + +import java.io.Closeable; + +import io.temporal.serviceclient.WorkflowServiceStubs; +import lombok.Getter; +import lombok.extern.slf4j.Slf4j; + +/** + * A wrapper class of {@link WorkflowServiceStubs} that implements the Closeable interface. + * It manages the lifecycle of {@link WorkflowServiceStubs}, ensuring proper shutdown and resource cleanup. + */ +@Getter +@Slf4j +public class ManagedWorkflowServiceStubs implements Closeable { + private final WorkflowServiceStubs workflowServiceStubs; + + public ManagedWorkflowServiceStubs(WorkflowServiceStubs serviceStubs) { + this.workflowServiceStubs = serviceStubs; + } + + @Override + public void close() { + try { + workflowServiceStubs.getOptions().getMetricsScope().close(); Review Comment: If there is no metrics scope present it would be caught in catch block. Shutdown will not be executed. Since shutdown was anyway not being called until now, felt it might not be super important in such cases. Updated the code where metrics scope is now closed in a nested `try-finally` block. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@gobblin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
