pratapaditya04 commented on code in PR #4098:
URL: https://github.com/apache/gobblin/pull/4098#discussion_r1957702136
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/cluster/GobblinTemporalTaskRunner.java:
##########
@@ -151,8 +151,7 @@ public GobblinTemporalTaskRunner(String applicationName,
this.containerMetrics = buildContainerMetrics();
this.numTemporalWorkers = ConfigUtils.getInt(config,
GobblinTemporalConfigurationKeys.TEMPORAL_NUM_WORKERS_PER_CONTAINER,
GobblinTemporalConfigurationKeys.DEFAULT_TEMPORAL_NUM_WORKERS_PER_CONTAINERS);
- this.temporalQueueName = ConfigUtils.getString(config,
GobblinTemporalConfigurationKeys.GOBBLIN_TEMPORAL_TASK_QUEUE,
- GobblinTemporalConfigurationKeys.DEFAULT_GOBBLIN_TEMPORAL_TASK_QUEUE);
+ this.temporalQueueName =
GobblinTemporalConfigurationKeys.getTemporalTaskQueueName(config);
Review Comment:
yeah,looks like dead code, temporalQueueName variable is not used. let me
clean it up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
