[
https://issues.apache.org/jira/browse/GOBBLIN-2194?focusedWorklogId=957359&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-957359
]
ASF GitHub Bot logged work on GOBBLIN-2194:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 17/Feb/25 12:51
Start Date: 17/Feb/25 12:51
Worklog Time Spent: 10m
Work Description: khandelwal-prateek commented on code in PR #4097:
URL: https://github.com/apache/gobblin/pull/4097#discussion_r1958180609
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/workflows/service/ManagedWorkflowServiceStubs.java:
##########
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.gobblin.temporal.workflows.service;
+
+import java.io.Closeable;
+
+import io.temporal.serviceclient.WorkflowServiceStubs;
+import lombok.Getter;
+import lombok.extern.slf4j.Slf4j;
+
+/**
+ * A wrapper class of {@link WorkflowServiceStubs} that implements the
Closeable interface.
+ * It manages the lifecycle of {@link WorkflowServiceStubs}, ensuring proper
shutdown and resource cleanup.
+ */
+@Getter
+@Slf4j
+public class ManagedWorkflowServiceStubs implements Closeable {
+ private final WorkflowServiceStubs workflowServiceStubs;
+
+ public ManagedWorkflowServiceStubs(WorkflowServiceStubs serviceStubs) {
+ this.workflowServiceStubs = serviceStubs;
+ }
+
+ @Override
+ public void close() {
+ try {
+ try {
+ workflowServiceStubs.getOptions().getMetricsScope().close();
+ }
+ finally {
+ workflowServiceStubs.shutdown();
+ }
+ }
+ catch (Exception e) {
+ log.error("Exception occurred while closing
ManagedWorkflowServiceStubs", e);
Review Comment:
> closing metrics scope is not that critical
the only impact is that yarn AM would take longer to complete and not
shutdown immediately, right?
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/workflows/service/ManagedWorkflowServiceStubs.java:
##########
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.gobblin.temporal.workflows.service;
+
+import java.io.Closeable;
+
+import io.temporal.serviceclient.WorkflowServiceStubs;
+import lombok.Getter;
+import lombok.extern.slf4j.Slf4j;
+
+/**
+ * A wrapper class of {@link WorkflowServiceStubs} that implements the
Closeable interface.
+ * It manages the lifecycle of {@link WorkflowServiceStubs}, ensuring proper
shutdown and resource cleanup.
+ */
+@Getter
+@Slf4j
+public class ManagedWorkflowServiceStubs implements Closeable {
+ private final WorkflowServiceStubs workflowServiceStubs;
+
+ public ManagedWorkflowServiceStubs(WorkflowServiceStubs serviceStubs) {
+ this.workflowServiceStubs = serviceStubs;
+ }
+
+ @Override
+ public void close() {
+ try {
+ try {
+ workflowServiceStubs.getOptions().getMetricsScope().close();
+ }
+ finally {
+ workflowServiceStubs.shutdown();
+ }
Review Comment:
if both metricsScope.close() and shutdown() fail, the current structure logs
only one exception (shutdown failure), making it harder to debug issue. Also,
separate try-catch blocks makes it explicit that shutdown is always attempted,
regardless of MetricsScope.close() success
Issue Time Tracking
-------------------
Worklog Id: (was: 957359)
Time Spent: 3h 40m (was: 3.5h)
> Fix Temporal metrics scope closure bug
> --------------------------------------
>
> Key: GOBBLIN-2194
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2194
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-metrics
> Reporter: Abhishek Jain
> Assignee: Issac Buenrostro
> Priority: Major
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
> As part of https://issues.apache.org/jira/browse/GOBBLIN-2192 a bug was
> introduced where the metrics scope object was not closed resulting in AM
> container not shutting down.
> Metrics scope should be closed wherever initialized.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
