pratapaditya04 commented on code in PR #4109:
URL: https://github.com/apache/gobblin/pull/4109#discussion_r2028845247
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/task/DagTask.java:
##########
@@ -65,10 +65,11 @@ public boolean conclude() {
boolean completedLease = this.leaseObtainedStatus.completeLease();
this.dagProcEngineMetrics.markDagActionsConclude(this.dagAction.getDagActionType(),
completedLease);
return completedLease;
- } catch (IOException e) {
+ } catch (Exception e) {
this.dagProcEngineMetrics.markDagActionsConclude(this.dagAction.getDagActionType(),
false);
// TODO: Decide appropriate exception to throw and add to the commit
method's signature
- throw new RuntimeException(e);
+ log.error("Exception encountered in processing this DagTask.", e);
Review Comment:
can we add dag details also in the log line?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
