[
https://issues.apache.org/jira/browse/GOBBLIN-2200?focusedWorklogId=966942&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-966942
]
ASF GitHub Bot logged work on GOBBLIN-2200:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 21/Apr/25 13:26
Start Date: 21/Apr/25 13:26
Worklog Time Spent: 10m
Work Description: abhishekmjain commented on code in PR #4108:
URL: https://github.com/apache/gobblin/pull/4108#discussion_r2052384155
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/ddm/work/assistance/Help.java:
##########
@@ -104,9 +103,9 @@ public static String
calcPerExecQualifierWithOptFlowExecId(FileSystemJobStateful
public static String calcPerExecQualifier(Config workerConfig) {
String userToProxy = workerConfig.hasPath(USER_TO_PROXY_KEY)
? workerConfig.getString(USER_TO_PROXY_KEY) : "";
- String azFlowExecId = workerConfig.hasPath(AZKABAN_FLOW_EXEC_ID_KEY)
- ? workerConfig.getString(AZKABAN_FLOW_EXEC_ID_KEY) :
UUID.randomUUID().toString();
- return userToProxy + "_" + azFlowExecId;
+ String gaasFlowExecId =
workerConfig.hasPath(ConfigurationKeys.GAAS_JOB_EXEC_ID)
+ ? workerConfig.getString(ConfigurationKeys.GAAS_JOB_EXEC_ID) :
UUID.randomUUID().toString();
Review Comment:
I believe this code is getting used only in executor where the jar will not
be updated during deployment, unlike service where the deployment will affect
currently running jobs.
Can you please confirm if that is the intention behind not adding a fallback
here?
Or is this getting used somewhere in service and we are still not adding a
fallback for some reason?
Issue Time Tracking
-------------------
Worklog Id: (was: 966942)
Time Spent: 40m (was: 0.5h)
> Moving Away From Azkaban Execution Id
> -------------------------------------
>
> Key: GOBBLIN-2200
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2200
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Aditya Pratap Singh
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Moving Away From Azkaban Execution Id
> In several places we use azkaban.flow.exec.id config values to identify the
> jobExecution, since we don't want to tie Gobblin to Azkaban, introducing a
> new field
> gaas.job.execid which will serve as the configuration Key for a unique job
> execution identifier in GaaS, the value is a UUID
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
