[
https://issues.apache.org/jira/browse/GOBBLIN-2207?focusedWorklogId=969113&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-969113
]
ASF GitHub Bot logged work on GOBBLIN-2207:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 09/May/25 08:15
Start Date: 09/May/25 08:15
Worklog Time Spent: 10m
Work Description: khandelwal-prateek commented on code in PR #4116:
URL: https://github.com/apache/gobblin/pull/4116#discussion_r2081168223
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/ddm/work/assistance/Help.java:
##########
@@ -105,7 +106,9 @@ public static String calcPerExecQualifier(Config
workerConfig) {
? workerConfig.getString(USER_TO_PROXY_KEY) : "";
String gaasFlowExecId =
workerConfig.hasPath(ConfigurationKeys.GAAS_JOB_EXEC_ID)
? workerConfig.getString(ConfigurationKeys.GAAS_JOB_EXEC_ID) :
UUID.randomUUID().toString();
- return userToProxy + "_" + gaasFlowExecId;
+ String gaasAttemptId =
workerConfig.hasPath(ConfigurationKeys.JOB_CURRENT_ATTEMPTS)
Review Comment:
please change the config `JOB_CURRENT_ATTEMPTS` to `JOB_ATTEMPT_ID` for
better clarity. The current name is a bit misleading and seems like a count
rather than a unique attempt identifier.
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/ddm/work/assistance/Help.java:
##########
@@ -105,7 +106,9 @@ public static String calcPerExecQualifier(Config
workerConfig) {
? workerConfig.getString(USER_TO_PROXY_KEY) : "";
String gaasFlowExecId =
workerConfig.hasPath(ConfigurationKeys.GAAS_JOB_EXEC_ID)
? workerConfig.getString(ConfigurationKeys.GAAS_JOB_EXEC_ID) :
UUID.randomUUID().toString();
- return userToProxy + "_" + gaasFlowExecId;
+ String gaasAttemptId =
workerConfig.hasPath(ConfigurationKeys.JOB_CURRENT_ATTEMPTS)
+ ? workerConfig.getString(ConfigurationKeys.JOB_CURRENT_ATTEMPTS) :
DEFAULT_GAAS_ATTEMPT_ID;
+ return userToProxy + "_" + gaasFlowExecId + "_" + gaasAttemptId;
Review Comment:
can use `String.join("_", userToProxy, gaasFlowExecId, gaasAttemptId);`
Issue Time Tracking
-------------------
Worklog Id: (was: 969113)
Remaining Estimate: 0h
Time Spent: 10m
> Make Temporal Execution Url Attempt aware
> -----------------------------------------
>
> Key: GOBBLIN-2207
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2207
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Aditya Pratap Singh
> Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Make Temporal Execution Url Attempt aware
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
