khandelwal-prateek commented on code in PR #4116:
URL: https://github.com/apache/gobblin/pull/4116#discussion_r2081168223
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/ddm/work/assistance/Help.java:
##########
@@ -105,7 +106,9 @@ public static String calcPerExecQualifier(Config
workerConfig) {
? workerConfig.getString(USER_TO_PROXY_KEY) : "";
String gaasFlowExecId =
workerConfig.hasPath(ConfigurationKeys.GAAS_JOB_EXEC_ID)
? workerConfig.getString(ConfigurationKeys.GAAS_JOB_EXEC_ID) :
UUID.randomUUID().toString();
- return userToProxy + "_" + gaasFlowExecId;
+ String gaasAttemptId =
workerConfig.hasPath(ConfigurationKeys.JOB_CURRENT_ATTEMPTS)
Review Comment:
please change the config `JOB_CURRENT_ATTEMPTS` to `JOB_ATTEMPT_ID` for
better clarity. The current name is a bit misleading and seems like a count
rather than a unique attempt identifier.
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/ddm/work/assistance/Help.java:
##########
@@ -105,7 +106,9 @@ public static String calcPerExecQualifier(Config
workerConfig) {
? workerConfig.getString(USER_TO_PROXY_KEY) : "";
String gaasFlowExecId =
workerConfig.hasPath(ConfigurationKeys.GAAS_JOB_EXEC_ID)
? workerConfig.getString(ConfigurationKeys.GAAS_JOB_EXEC_ID) :
UUID.randomUUID().toString();
- return userToProxy + "_" + gaasFlowExecId;
+ String gaasAttemptId =
workerConfig.hasPath(ConfigurationKeys.JOB_CURRENT_ATTEMPTS)
+ ? workerConfig.getString(ConfigurationKeys.JOB_CURRENT_ATTEMPTS) :
DEFAULT_GAAS_ATTEMPT_ID;
+ return userToProxy + "_" + gaasFlowExecId + "_" + gaasAttemptId;
Review Comment:
can use `String.join("_", userToProxy, gaasFlowExecId, gaasAttemptId);`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
