NamsB7 commented on code in PR #4121:
URL: https://github.com/apache/gobblin/pull/4121#discussion_r2221872669
##########
gobblin-api/src/main/java/org/apache/gobblin/configuration/Category.java:
##########
@@ -0,0 +1,22 @@
+package org.apache.gobblin.configuration;
+
+import java.io.Serializable;
+
+/**
+ * POJO representing a Category, similar to Spec or State.
Review Comment:
Added description for this.
##########
gobblin-api/src/main/java/org/apache/gobblin/configuration/ConfigurationKeys.java:
##########
@@ -85,6 +85,14 @@ public class ConfigurationKeys {
public static final String DATASETURN_STATESTORE_NAME_PARSER =
"state.store.datasetUrnStateStoreNameParser";
+ /**
+ * Error Pattern Store related to configuration properties.
+ */
+ public static final String ERROR_REGEX_DB_TABLE_KEY =
"state.store.db.regexTableName";
+ public static final String ERROR_CATEGORIES_DB_TABLE_KEY =
"state.store.db.categoriesTableName";
+ public static final String ERROR_REGEX_MAX_VARCHAR_SIZE_KEY =
"error.regex.max.varchar.size";
+ public static final String ERROR_CATEGORY_MAX_VARCHAR_SIZE_KEY =
"error.category.max.varchar.size";
Review Comment:
Noted, has been changed accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
