abhishekmjain commented on code in PR #4124:
URL: https://github.com/apache/gobblin/pull/4124#discussion_r2234598813
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/ddm/workflow/impl/ExecuteGobblinWorkflowImpl.java:
##########
@@ -85,6 +85,9 @@ public ExecGobblinStats execute(Properties jobProps,
EventSubmitterContext event
// Filtering only temporal job properties to pass to child workflows to
avoid passing unnecessary properties
Review Comment:
nit: please update this comment
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/ddm/workflow/impl/ExecuteGobblinWorkflowImpl.java:
##########
@@ -85,6 +85,9 @@ public ExecGobblinStats execute(Properties jobProps,
EventSubmitterContext event
// Filtering only temporal job properties to pass to child workflows to
avoid passing unnecessary properties
final Properties temporalJobProps =
PropertiesUtils.extractPropertiesWithPrefix(jobProps,
com.google.common.base.Optional.of(GobblinTemporalConfigurationKeys.PREFIX));
+ // Add File system properties to the temporal job properties
Review Comment:
how many properties are getting added as part of this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
