[
https://issues.apache.org/jira/browse/GOBBLIN-2213?focusedWorklogId=976472&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-976472
]
ASF GitHub Bot logged work on GOBBLIN-2213:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 28/Jul/25 04:01
Start Date: 28/Jul/25 04:01
Worklog Time Spent: 10m
Work Description: abhishekmjain commented on code in PR #4124:
URL: https://github.com/apache/gobblin/pull/4124#discussion_r2234598813
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/ddm/workflow/impl/ExecuteGobblinWorkflowImpl.java:
##########
@@ -85,6 +85,9 @@ public ExecGobblinStats execute(Properties jobProps,
EventSubmitterContext event
// Filtering only temporal job properties to pass to child workflows to
avoid passing unnecessary properties
Review Comment:
nit: please update this comment
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/ddm/workflow/impl/ExecuteGobblinWorkflowImpl.java:
##########
@@ -85,6 +85,9 @@ public ExecGobblinStats execute(Properties jobProps,
EventSubmitterContext event
// Filtering only temporal job properties to pass to child workflows to
avoid passing unnecessary properties
final Properties temporalJobProps =
PropertiesUtils.extractPropertiesWithPrefix(jobProps,
com.google.common.base.Optional.of(GobblinTemporalConfigurationKeys.PREFIX));
+ // Add File system properties to the temporal job properties
Review Comment:
how many properties are getting added as part of this?
Issue Time Tracking
-------------------
Worklog Id: (was: 976472)
Time Spent: 0.5h (was: 20m)
> Pass FileSystem properties to Temporal Activities
> -------------------------------------------------
>
> Key: GOBBLIN-2213
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2213
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Vivek Rai
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Pass FileSystem properties to Temporal Activities
> Currently temporal activities don't propagate filesystem property, we need to
> pass the required properties to create FIleSystem with required configurations
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
