abhishekmjain commented on code in PR #4135:
URL: https://github.com/apache/gobblin/pull/4135#discussion_r2292643985
##########
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/Task.java:
##########
@@ -334,9 +334,7 @@ private void computeAndUpdateTaskDataQuality() {
Log.warn("Unknown data quality status encountered: " + result);
forkDataQualityStatus = DataQualityStatus.UNKNOWN;
}
- if (DataQualityStatus.FAILED == forkDataQualityStatus) {
- overallTaskDataQuality = DataQualityStatus.FAILED;
- }
+ overallTaskDataQuality = forkDataQualityStatus;
Review Comment:
do we need to change the earlier case to this?
If we have 3 forks, with success, fail, success, the third iteration will
mark overallTaskDataQuality as success, right?
If we want to factor for not evaluated, we can have success can go to
NE/fail. NE can go to fail. Fail cannot be changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
