thisisArjit commented on code in PR #4131:
URL: https://github.com/apache/gobblin/pull/4131#discussion_r2299810704
##########
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/iceberg/IcebergPartitionDataset.java:
##########
@@ -191,8 +192,8 @@ private Map<Path, FileStatus>
calcSrcFileStatusByDestFilePath(Map<Path, DataFile
Map<Path, FileStatus> srcFileStatusByDestFilePath = Maps.newHashMap();
try {
Review Comment:
it is only initialisation, so not required but will change it to
ConcurrentHashMap
##########
gobblin-data-management/src/test/java/org/apache/gobblin/data/management/copy/iceberg/IcebergOverwritePartitionsStepTest.java:
##########
@@ -53,15 +54,23 @@ public void setUp() throws IOException {
mockProperties = new Properties();
List<DataFile> dummyDataFiles = createDummyDataFiles();
- serializedDummyDataFiles =
SerializationUtil.serializeToBytes(dummyDataFiles);
+ base64EncodedDataFiles = getEncodedDataFiles(dummyDataFiles);
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
