abhishekmjain commented on code in PR #4136:
URL: https://github.com/apache/gobblin/pull/4136#discussion_r2303098245


##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/task/DagProcessingEngineMetrics.java:
##########
@@ -163,6 +167,14 @@ public void 
markDagActionsConclude(DagActionStore.DagActionType dagActionType, b
     }
   }
 
+  public void 
markDagActionsConflowFlowSpecRemoval(DagActionStore.DagActionType 
dagActionType, boolean succeeded) {
+    if (succeeded) {
+      
updateMetricForDagActionType(this.dagActionsConcludeFlowSpecRemovalSucceededMetreByDagActionType,
 dagActionType);
+    } else {

Review Comment:
   can you please elaborate on what is added?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to