Blazer-007 commented on code in PR #4134:
URL: https://github.com/apache/gobblin/pull/4134#discussion_r2314349733
##########
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/CopyEntity.java:
##########
@@ -66,7 +69,7 @@ public class CopyEntity implements HasGuid {
@Override
public Guid guid() throws IOException {
- return Guid.fromStrings(toString());
+ return id;
}
Review Comment:
This change is not fully backward compatible, given guid usage in
`DistcpSplitter` and `RecoveryHelper` which are used in `CopyDataPublisher` and
`FIleAwareInputStreamWriter`, lets make this change atleast backward compatible
by adding a new function which accepts `boolean createGuidFromUuid` and pass
this as yes from the caller where we are anticipating this to be called and in
case no default to original way
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
