abhishekmjain commented on code in PR #4143:
URL: https://github.com/apache/gobblin/pull/4143#discussion_r2377956714
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/ddm/workflow/impl/ExecuteGobblinWorkflowImpl.java:
##########
@@ -156,6 +168,55 @@ public ExecGobblinStats execute(Properties jobProps,
EventSubmitterContext event
}
}
+ /**
+ * Emit metrics to indicate success or failure of a Gobblin job at RM level
+ * @param jobProps job properties
+ * @param isSuccess true if job is successful, false otherwise
+ */
+ private void emitMetrics(Properties jobProps, boolean isSuccess) {
+ JobState jobState = new JobState(jobProps);
+ try {
+ OpenTelemetryMetricsBase otelMetrics =
OpenTelemetryMetrics.getInstance(jobState);
+ if (otelMetrics == null) {
+ log.warn("OpenTelemetry metrics instance is null, skipping metrics
emission");
+ return;
+ }
+
+ Meter meter = otelMetrics.getMeter(GAAS_OBSERVABILITY_METRICS_GROUPNAME);
+ Attributes tags = getEventAttributes(jobState);
+ log.info("Emitting metrics for job: {}", jobState.getJobName());
Review Comment:
nit: should we have it as debug?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
