abhishekmjain commented on code in PR #4144:
URL: https://github.com/apache/gobblin/pull/4144#discussion_r2377997624
##########
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/JobContext.java:
##########
@@ -190,32 +189,6 @@ public JobContext(Properties jobProps, Logger logger,
SharedResourcesBroker<Gobb
.getPropAsInt(ConfigurationKeys.DATASET_COMMIT_THREADS,
ConfigurationKeys.DEFAULT_DATASET_COMMIT_THREADS) : 1;
}
- protected DatasetStateStore createStateStore(Config jobConfig)
Review Comment:
Let's not remove the function from here, instead call the util function here
and return
##########
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/util/DataStateStoreUtils.java:
##########
@@ -0,0 +1,101 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.gobblin.runtime.util;
+
+import java.io.IOException;
+
+import lombok.extern.slf4j.Slf4j;
+
+import com.typesafe.config.Config;
+
+import org.apache.gobblin.configuration.ConfigurationKeys;
+import org.apache.gobblin.metastore.DatasetStateStore;
+import org.apache.gobblin.util.ClassAliasResolver;
+import org.apache.gobblin.util.ConfigUtils;
+
+
+/**
+ * Utilities for creating and managing {@link DatasetStateStore} instances
based on job configuration.
+ */
+@Slf4j
+public class DataStateStoreUtils {
Review Comment:
I believe `DatasetStateStoreUtils` would be more apt
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
