Blazer-007 commented on code in PR #4146: URL: https://github.com/apache/gobblin/pull/4146#discussion_r2462950047
########## gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/iceberg/IcebergSource.java: ########## Review Comment: Can we add below improvements in this as similar to `CopySource` 1. Add support for simulate mode. 2. Set [ServiceConfigKeys.WORK_UNIT_SIZE](https://github.com/apache/gobblin/blob/master/gobblin-utility/src/main/java/org/apache/gobblin/util/WorkUnitSizeInfo.java#L77) detail in Workunit to better use of dynamic scaling based on size than based on file count (i.e. workunit count). 3. Introduce binPacking for workunits -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
