pratapaditya04 opened a new pull request, #4158:
URL: https://github.com/apache/gobblin/pull/4158

   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I 
have checked off all the steps below!
   
   
   ### JIRA
   - [ ] My PR addresses the following [Gobblin 
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references 
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
       - https://issues.apache.org/jira/browse/GOBBLIN-2242
   
   
   ### Description
   - [ ] Here are some details about my PR, including screenshots (if 
applicable):
   Summary
   Add SSL mode support for MySQL connections in MysqlStateStore with 
sslMode=VERIFY_IDENTITY when enabled via configuration.
   Changes
   ConfigurationKeys.java: Fixed constant STATE_STORE_DB_SSL_MODE_ENABLED (was 
incorrectly mapped to "state.store.db.user")
   MysqlStateStore.java:
   Added constants SSL_MODE_PROPERTY and SSL_MODE_VERIFY_IDENTITY
   Added conditional logic to set sslMode=VERIFY_IDENTITY driver property when 
state.store.db.sslModeEnabled=true
   MysqlStateStoreTest.java: Added 3 test cases covering 
enabled/disabled/default SSL mode configurations
   
   ### Tests
   - [ ] My PR adds the following unit tests __OR__ does not need testing for 
this extremely good reason:
   
   
   ### Commits
   - [ ] My commits all reference JIRA issues in their subject lines, and I 
have squashed multiple commits if they address the same issue. In addition, my 
commits follow the guidelines from "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to