Blazer-007 commented on code in PR #4185: URL: https://github.com/apache/gobblin/pull/4185#discussion_r3055778830
########## gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/iceberg/IcebergSource.java: ########## @@ -96,9 +96,14 @@ * # --- Recommended: configurable partition value format --- * # iceberg.partition.value.datetime.format is a DateTimeFormatter pattern applied to the output * # partition value used in the filter expression. - * # When CURRENT_DATE is used, the reference datetime is LocalDateTime.now(), so a pattern - * # with HH will embed the current hour automatically — no separate hour config needed. * # When set, it supersedes iceberg.hourly.partition.enabled. + * # + * # CURRENT_DATE behaviour: + * # - With iceberg.partition.value.datetime.format set → LocalDateTime.now(), so HH embeds the live clock-hour. + * # - Without iceberg.partition.value.datetime.format (legacy) and hourly.partition.enabled=true → + * # LocalDate.now() at midnight, HH stays -00 (backward compat). + * # - Without iceberg.partition.value.datetime.format (legacy) and hourly.partition.enabled=false → Review Comment: hourly enabled flag is legacy , right ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
