adithya2754 commented on code in PR #4191:
URL: https://github.com/apache/gobblin/pull/4191#discussion_r3239199840
##########
gobblin-api/src/main/java/org/apache/gobblin/configuration/ConfigurationKeys.java:
##########
@@ -179,6 +179,10 @@ public class ConfigurationKeys {
public static final String FLOW_EDGE_ID_KEY = "flow.edgeId";
public static final String FLOW_DESCRIPTION_KEY = "flow.description";
public static final String FLOW_EXECUTION_ID_KEY = "flow.executionId";
+ // Stamped onto the JobSpec config by LaunchDagProc, carrying the DagAction
store row-insert time in millis
+ // (sourced upstream from the CDC binlog event timestamp). Enables
downstream executors to measure end-to-end
+ // LAUNCH-to-submission latency including CDC propagation. Absent / -1 when
the source timestamp is unknown.
Review Comment:
will r doing this `if (storeInsertTimeMillis !=
DagActionStore.LeaseParams.UNKNOWN_STORE_INSERT_TIME_MILLIS)`, will this be
ever `-1L`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
