agam-99 opened a new pull request, #4196: URL: https://github.com/apache/gobblin/pull/4196
Dear Gobblin maintainers, Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below! ### JIRA - [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR" - https://issues.apache.org/jira/browse/GOBBLIN-2263 ### Description - [x] Here are some details about my PR, including screenshots (if applicable): - Builds an execution-local `FlowSpec` in `LaunchDagProc` before adding per-launch metadata like `flow.executionId` and `dagAction.launch.storeInsertTimeMillis`. - Clears stale `dagAction.launch.storeInsertTimeMillis` from the launch copy before applying the current DagAction timestamp. - Avoids mutating the catalog/scheduled `FlowSpec`, preventing scheduled flows from retaining stale per-run latency anchors across launches. ### Tests - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason: - Updated `LaunchDagProcTest` to verify launch copies receive the current store-insert timestamp and do not mutate the source `FlowSpec`. - Updated `LaunchDagProcTest` to verify UNKNOWN store-insert time does not carry a stale timestamp into the launch copy. - `JAVA_HOME="$(/usr/libexec/java_home -v 1.8)" ./gradlew :gobblin-service:compileTestJava` - `JAVA_HOME="$(/usr/libexec/java_home -v 1.8)" ./gradlew :gobblin-service:checkstyleMain :gobblin-service:checkstyleTest` - Attempted `JAVA_HOME="$(/usr/libexec/java_home -v 1.8)" ./gradlew :gobblin-service:test --tests org.apache.gobblin.service.modules.orchestration.proc.LaunchDagProcTest`; the suite failed in `TestMetastoreDatabaseFactory` setup because Docker/Testcontainers is not available in this environment. ### Commits - [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 2. Subject is limited to 50 characters 3. Subject does not end with a period 4. Subject uses the imperative mood ("add", not "adding") 5. Body wraps at 72 characters 6. Body explains "what" and "why", not "how" Made with [Cursor](https://cursor.com) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
