thisisArjit opened a new pull request, #4205:
URL: https://github.com/apache/gobblin/pull/4205

   …in all states
   
   RECONNECTABLE_APPLICATION_STATES only listed five of the eight YARN 
application states (NEW, NEW_SAVING, SUBMITTED, ACCEPTED, RUNNING), so 
getReconnectableApplicationId() -- which queries
   yarnClient.getApplications(APPLICATION_TYPES, 
RECONNECTABLE_APPLICATION_STATES) -- could never rediscover an application that 
had already moved into a terminal state (FINISHED, FAILED, KILLED). On driver 
restart such an application was treated as absent and a brand new one was 
launched instead of reconnecting to the existing one.
   
   Use EnumSet.allOf(YarnApplicationState.class) so the launcher considers 
applications in every state when searching for one to reconnect to. This also 
keeps the behavior correct if new YARN application states are added in the 
future.
   
   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I 
have checked off all the steps below!
   
   
   ### JIRA
   - [ ] My PR addresses the following [Gobblin 
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references 
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
       - https://issues.apache.org/jira/browse/GOBBLIN-XXX
   
   
   ### Description
   - [ ] Here are some details about my PR, including screenshots (if 
applicable):
   
   
   ### Tests
   - [ ] My PR adds the following unit tests __OR__ does not need testing for 
this extremely good reason:
   
   
   ### Commits
   - [ ] My commits all reference JIRA issues in their subject lines, and I 
have squashed multiple commits if they address the same issue. In addition, my 
commits follow the guidelines from "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to