[
https://issues.apache.org/jira/browse/GOBBLIN-27?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16102380#comment-16102380
]
Hung Tran edited comment on GOBBLIN-27 at 7/26/17 10:29 PM:
------------------------------------------------------------
PR: https://github.com/apache/incubator-gobblin/pull/2017
[^GOBBLIN-27-0.patch]
was (Author: hutran):
PR: https://github.com/apache/incubator-gobblin/pull/2017
> SQL Server - incomplete JDBC URL
> --------------------------------
>
> Key: GOBBLIN-27
> URL: https://issues.apache.org/jira/browse/GOBBLIN-27
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Abhishek Tiwari
> Assignee: Arjun Singh Bora
> Attachments: GOBBLIN-27-0.patch
>
>
> The connection URL lacks the database name. The URL returned by
> getConnectionUrl() (in SqlServerExtractor.java) looks like this
> `jdbc:sqlserver://sql_server_host:1433` but should be
> `jdbc:sqlserver://sql_server_host:1433;databaseName=myDb` (similar to what is
> done for MySQL).
> I propose the following fix
> `String database =
> this.workUnitState.getProp(ConfigurationKeys.SOURCE_QUERYBASED_SCHEMA);
> String url = jdbc:sqlserver:// + host.trim() + : + port + ;databaseName=
> + database.trim();`
>
> *Github Url* : https://github.com/linkedin/gobblin/issues/1867
> *Github Reporter* : *debelyoo*
> *Github Created At* : 2017-05-15T12:35:44Z
> *Github Updated At* : 2017-05-16T05:58:33Z
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)