Hi I have checked some content and I find the release good (well TBH I'm not as maniac as some others will be :-) ) I still there will be an issue regarding the gradle jar wrapper and I invite you to have a look at this comment https://s.apache.org/xFJg Otherwise all looks to be good for what I have checked. Cheers Olivier
On 4 January 2018 at 21:38, Lorand Bendig <lben...@gmail.com> wrote: > Thanks for the fix. > +1 > > Lorand > > 2018-01-04 2:56 GMT+01:00 Abhishek Tiwari <a...@apache.org>: > > > Oh, seems like that got missed too. Fixed it (wondering why it built for > > me). > > > > Regards, > > Abhishek > > > > On Thu, Jan 4, 2018 at 5:50 AM, Lorand Bendig <lben...@gmail.com> wrote: > > > > > Hi Abhishek, > > > > > > Thanks for the fix. > > > I think buildSrc/ is also missing because the two imports in > > > gradle/scripts/defaultBuildProperties.gradle cannot be resolved. > > > > > > Lorand > > > > > > 2018-01-03 23:18 GMT+01:00 Abhishek Tiwari <a...@apache.org>: > > > > > > > Hi Lorand, > > > > > > > > Thanks! Yes, it got excluded from the source tar. I have fixed it, > > please > > > > try again. > > > > > > > > Abhishek > > > > > > > > On Thu, Jan 4, 2018 at 3:11 AM, Lorand Bendig <lben...@gmail.com> > > wrote: > > > > > > > > > Thank you Abhishek. > > > > > I'm about to build it and run the tests but the gradle directory > > along > > > > with > > > > > the wrapper isn't there. > > > > > Am I missing something? > > > > > > > > > > Lorand > > > > > > > > > > 2018-01-03 21:01 GMT+01:00 Abhishek Tiwari <a...@apache.org>: > > > > > > > > > > > Hi all, > > > > > > > > > > > > I'd like to call a vote to release Apache Gobblin 0.12.0 > > > (Incubating). > > > > > > > > > > > > The source release candidate RC0 can be downloaded here: > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/incubator/gobblin/ > > > > > > apache-gobblin-incubating-0.12.0-rc0/ > > > > > > > > > > > > The artifacts (i.e. JARs) corresponding to this release candidate > > can > > > > be > > > > > > found here: > > > > > > > > > > > > https://repository.apache.org/content/repositories/ > > > > > orgapachegobblin-1000/ > > > > > > > > > > > > This has been signed with PGP key 234E3FE3, corresponding to > > > > > > a...@apache.org, which is included in the repository's KEYS > file. > > > > This > > > > > > key can be found on keyservers, such as: > > > > > > > > > > > > *http://pgp.mit.edu/pks/lookup?op=get&search=0x234E3FE3 > > > > > > <http://pgp.mit.edu/pks/lookup?op=get&search=0x234E3FE3>* > > > > > > > > > > > > It is also listed here: > > > > > > > > > > > > https://people.apache.org/keys/committer/abti.asc > > > > > > > > > > > > The release candidate has been tagged with release-0.12.0-rc0. > > > > > > I've also created a branch 0.12.0. > > > > > > > > > > > > For reference, here is a list of all closed JIRAs tagged with > > 0.12.0: > > > > > > > > > > > > https://issues.apache.org/jira/issues/?jql=project%20% > > > > > 3D%20GOBBLIN%20AND% > > > > > > 20fixVersion%20%3D%200.12.0%20AND%20status%20in%20(Closed% > > > > > > 2C%20Resolved)%20ORDER%20BY%20updatedDate%20DESC%2C% > > > > > > 20createdDate%20DESC%2C%20status%20DESC%2C%20priority%20DESC > > > > > > > > > > > > > > > > > > For a summary of the changes in this release, see: > > > > > > > > > > > > https://github.com/apache/incubator-gobblin/blob/0.12.0/ > > CHANGELOG.md > > > > > > > > > > > > Please review and vote. The vote will be open for 72 hours (ends > > on > > > > > > Saturday, 6 January 2018, 12 Noon PST). > > > > > > > > > > > > [ ] +1 approve > > > > > > [ ] +0 no opinion > > > > > > [ ] -1 disapprove (and reason why) > > > > > > > > > > > > My vote: +1 > > > > > > > > > > > > Thanks, > > > > > > Abhishek > > > > > > > > > > > > > > > > > > > > > -- Olivier Lamy http://twitter.com/olamy | http://linkedin.com/in/olamy
